-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update README.md #25
base: main
Are you sure you want to change the base?
Update README.md #25
Conversation
Had a few compile hiccups - updated to use be compatible with the latest Domino UI (1.0.0-RC13)
README.md
Outdated
@@ -137,6 +138,7 @@ public class PersonComponent implements IsElement<HTMLDivElement>, Editor<Person | |||
|
|||
private DominoElement<HTMLDivElement> root = DominoElement.of(div()); | |||
|
|||
//Note: Do not create getter/setters for these fields - it will cause a compile issue such as "java.lang.IllegalStateException: generation aborted! No getter exists for >>getId<< -> [Help 1]" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably we should have a bug report for this?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great feedback - updated thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bug Report Submitted
#26
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think, that there is a problem with the example. Please, take a look at my comment inside the issue.
README.md
Outdated
@@ -129,6 +129,7 @@ public class Person { | |||
> this component uses domino-ui | |||
|
|||
```java | |||
//Note place in *-client directory |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe specify "client project or package", since not all projects follow that archetype
Had a few compile hiccups - updated to use be compatible with the latest Domino UI (1.0.0-RC13)