Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #25

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Update README.md #25

wants to merge 4 commits into from

Conversation

jhillbounce
Copy link

Had a few compile hiccups - updated to use be compatible with the latest Domino UI (1.0.0-RC13)

Had a few compile hiccups - updated to use be compatible with the latest Domino UI (1.0.0-RC13)
README.md Outdated
@@ -137,6 +138,7 @@ public class PersonComponent implements IsElement<HTMLDivElement>, Editor<Person

private DominoElement<HTMLDivElement> root = DominoElement.of(div());

//Note: Do not create getter/setters for these fields - it will cause a compile issue such as "java.lang.IllegalStateException: generation aborted! No getter exists for >>getId<< -> [Help 1]"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

probably we should have a bug report for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great feedback - updated thank you!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bug Report Submitted
#26

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think, that there is a problem with the example. Please, take a look at my comment inside the issue.

README.md Outdated
@@ -129,6 +129,7 @@ public class Person {
> this component uses domino-ui

```java
//Note place in *-client directory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe specify "client project or package", since not all projects follow that archetype

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants