Fix "local variable 'file_type' referenced before assignment", and improve performance in common exif removal case #103
+46
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jim-meyer
commented
Jun 15, 2020
jim-meyer
commented
- Fixed "local variable 'file_type' referenced before assignment" if image type wasn't known.
- No longer write image back to source image file if nothing has changed for better performance. The motivation here is that I've got 10000+ of images that I need to remove exif data from. Many of the images have already had exif removed previously. Thus writing unchanged data back to the source file was making batch processing take a lot longer than it needed to.
added 2 commits
June 14, 2020 19:02
jim-meyer
changed the title
|
@hMatoba any chance of merging this, please? I depend on this fix |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.