ascii values without \x00 ending #127
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
in some images there are ascii values without terminating null character ( \x00 ). this is a fix for that case. It reduces all characters after a null character in an ascii text
homm
reviewed
Jan 20, 2022
| @@ -153,7 +153,8 @@ def convert_value(self, val): | |||
| elif t == TYPES.Ascii: # ASCII | |||
| if length > 4: | |||
| pointer = struct.unpack(self.endian_mark + "L", value)[0] | |||
| data = self.tiftag[pointer: pointer+length - 1] | |||
| data = self.tiftag[pointer: pointer+length] | |||
| data = data.split(b'\x00', 1)[0] | |||
| else: | |||
| data = value[0: length - 1] | |||
There was a problem hiding this comment.
This case is uncovered, data = data.split(b'\x00', 1)[0] should be after if statement.
mikhail-iurkov
added a commit
to uploadcare/Piexif
that referenced
this pull request
Jan 20, 2022
mikhail-iurkov
added a commit
to uploadcare/Piexif
that referenced
this pull request
Jan 21, 2022
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in some images there are ascii values without terminating null character ( \x00 ).
this is a fix for that case.
It reduces all characters after a null character in an ascii text
the Github- project exifread solves this problem the same way. Have a look at
https://github.com/ianare/exif-py/blob/develop/exifread/classes.py in method _process_field2 on line 193.