Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sprig App] heartgame #2720

Open
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

Tech-with-anmol
Copy link

Author name

Author: Tech-with-anmol

About your game

What is your game about?
this is a game where you have to save your heart from enemies, a fast paced and endless game

How do you play your game?
use key A and D for left and right movement and save yourself from enemies.

Copy link

vercel bot commented Dec 17, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
sprig ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 3, 2025 9:01pm

Copy link

You can play your game at Play Here!

Copy link
Member

@gusruben gusruben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your submission! I like the game, but unfortunately I'm getting an error after dying: TypeError: can't access property "x", p is undefined. If you fix this, I'd be happy to approve your game!

@gusruben gusruben self-assigned this Dec 20, 2024
@gusruben gusruben added the initial review performed This Sprig app PR has had initial feedback given, and is in a pending state of review label Dec 20, 2024
Copy link

You can play your game at Play Here!

@Tech-with-anmol
Copy link
Author

Tech-with-anmol commented Dec 21, 2024

hi, just update the code, look like I, by mistake removed the line "if (!p) return;" which was causing the issue. now it's all good.

Copy link

You can play your game at Play Here!

updated memory management for better performance and better error handling
Copy link

You can play your game at Play Here!

@Tech-with-anmol
Copy link
Author

Hi, I am really sorry for making changes two time, but I wanted to update the memory management for better performance and better error handling

Copy link

github-actions bot commented Jan 3, 2025

You can play your game at Play Here!

Copy link

github-actions bot commented Jan 3, 2025

You can play your game at Play Here!

Copy link
Contributor

@grymmy grymmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this game needs a bit more additional complexity to quality for a sprig grant.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
initial review performed This Sprig app PR has had initial feedback given, and is in a pending state of review submission Game submission
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants