Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: reduce bundle size #4

Merged
merged 2 commits into from
Oct 3, 2024
Merged

chore: reduce bundle size #4

merged 2 commits into from
Oct 3, 2024

Conversation

EastSun5566
Copy link
Contributor

Removing unused deps and moving socket.io-client from devDeps to deps can reduce the bundle size:

Before:
Screenshot 2024-10-03 at 11 03 15 AM

After:
Screenshot 2024-10-03 at 11 01 30 AM

@EastSun5566 EastSun5566 self-assigned this Oct 3, 2024
stanley2058
stanley2058 approved these changes Oct 3, 2024
View reviewed changes
Copy link
Collaborator

@stanley2058 stanley2058 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@stanley2058 stanley2058 merged commit 0e83865 into main Oct 3, 2024
1 check passed
@Yukaii Yukaii deleted the chore/reduce-bundle-size branch October 3, 2024 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stanley2058 stanley2058 stanley2058 approved these changes

Assignees

@EastSun5566 EastSun5566

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@EastSun5566 @stanley2058