Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

transaction - fix CLI command, close a suggestion for text input #110

Merged
merged 2 commits into from
Nov 6, 2023
Merged

transaction - fix CLI command, close a suggestion for text input #110

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
058de02
transaction - fix CLI command, close the suggestions
kstekovi Nov 2, 2023
c8fb210
use blur to lose focus
kstekovi Nov 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/commands/src/add-data-source.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ export class AddDataSource {

toCLICommand(): string {
return (
'"data-source add --name= ' +
'"data-source add --name=' +
this.name +
" --jndi-name=" +
this.jndiName +
Expand Down
8 changes: 4 additions & 4 deletions ...suite/cypress/e2e/transaction/transactions-configuration-subsystem-transaction-jdbc.cy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,20 +20,20 @@ describe("TESTS: Configuration => Sybsystem => Transaction => Path", () => {

const datasourceBase = {
connectionUrl:
"jdbc:h2:mem:test;DB_CLOSE_DELAY=-1;DB_CLOSE_ON_EXIT=FALSE;MODE=${wildfly.h2.compatibility.mode:REGULAR}",
"jdbc:h2:mem:test;DB_CLOSE_DELAY=-1;DB_CLOSE_ON_EXIT=FALSE;MODE=\\${wildfly.h2.compatibility.mode:REGULAR}",
driverName: "h2",
};

const nonEmptyDS = {
...datasourceBase,
name: "nonEmptyDS",
jndiName: "java:jboss/datasources/nonEmptyDS,",
OndrejKotek marked this conversation as resolved.
Show resolved Hide resolved
jndiName: "java:jboss/datasources/nonEmptyDS",
};

const nonEmptyDSUpdated = {
...datasourceBase,
name: "nonEmptyDS",
jndiName: "java:jboss/datasources/nonEmptyDS,",
name: "nonEmptyDSUpdated",
jndiName: "java:jboss/datasources/nonEmptyDSUpdated",
};

// Here we start our WildFly container prior to test execution
Expand Down
4 changes: 3 additions & 1 deletion packages/testsuite/cypress/support/form-editing.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -141,6 +141,8 @@ Cypress.Commands.add(
formInput.type(value as string, { parseSpecialCharSequences: parseSpecialCharSequences });
formInput.should("have.value", value);
formInput.trigger("change");
// lose focus of current input to close suggestions which can hide buttons.
formInput.blur();
}
);

Expand Down Expand Up @@ -305,7 +307,7 @@ declare global {
*/
clearAttribute(formId: string, attributeName: string): Chainable<void>;
/**
* Select value from <select> input which isn't part of a form.
* Select value from <select> input which isn't part of a form.
* @category Data inserting
*
* @example The form input have select with id "#dw-routing-select"
Expand Down