Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve .exe matching accuracy #303

Merged
merged 8 commits into from
Nov 4, 2024
Merged

Improve .exe matching accuracy #303

merged 8 commits into from
Nov 4, 2024

Conversation

roblabla
Copy link
Member

@roblabla roblabla commented Nov 3, 2024

This PR:

  • Reorders the object files to roughly match the order in the original binary
  • Adds /opt:ref to delete unused functions, which is necessary as the compiler auto-generates some unused symbols otherwise.
  • Implements Supervisor::DeletedCallback, to avoid some functions from getting removed by /opt:ref
  • Cleans up unused functions in FileSystem.hpp
  • Reorders functions in AnmVm.obj and Stage.obj.

@roblabla
Implement Supervisor::DeletedCallback
295dea7
@roblabla
Add /opt:ref to linker flags
f92c110 
We want the linker to eliminate unused symbols, as otherwise we'll get
some extra functions getting included in our binary. Normally, /opt:ref
is enabled by default. However, since we add the /DEBUG flag to get a
PDB, /opt:noref actually gets enabled by default, so we need to override
this.
@roblabla
Reorder objects to more closely match the final binary
1132408
@roblabla
Remove two unused functions from FileSystem.hpp
08b3f9c 
Those two functions aren't actually th06 functions, but the CRT _chdir
and _mkdir functions.
@roblabla
Improve AnmVm.obj accuracy
cf7f8cd
@roblabla
Reorder Stage.obj function order to match original binary
a062e37
@roblabla
Move AnmManager::ExecuteAnmIdx to Stage.obj
fe96674
@roblabla
Move BombData to dedicated BombData.obj
d6cfb3f
@roblabla roblabla force-pushed the perfect-bin-match-asciimanager branch from a075d52 to d6cfb3f Compare November 4, 2024 22:47
@roblabla roblabla merged commit 970e5a8 into happyhavoc:master Nov 4, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@roblabla