Improve Pbg3Archive accuracy #321
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
88% -> 98%
82% -> 100%
84% -> 100%
roblabla
reviewed
Nov 14, 2024
src/pbg3/Pbg3Archive.cpp
Outdated
| { | ||
| return -1; | ||
| } | ||
| // Why was this here? It's certainly not present in the assembly. |
There was a problem hiding this comment.
The PBG3 code wasn't a very faithful reimpl - I was more concerned in having something that worked than something that matched, so I could move on to the actual game logic faster.
So in that context, this might have been put here as a workaround or something while working on it. Anyways, you can delete these lines - they're indeed not from the original ^^.
There was a problem hiding this comment.
(I might also have used various open source PBG3 impls as references, like thtk, which may be where this came from? Not sure)
|
Very nice work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pbg3Archive::Load88% -> 98%Pbg3Archive::FindEntry82% -> 100%Pbg3Archive::GetEntrySize84% -> 100%There is currently an issue with the codegen for
Pbg3Parser's scalar deleting destructor that is preventingPbg3Archive::LoadandPbg3Archive::ParseHeaderfrom matching.