Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CMyFont #349

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Add CMyFont #349

merged 4 commits into from
Dec 22, 2024

Conversation

Renzo904
Copy link
Member

@Renzo904 Renzo904 commented Dec 2, 2024

Original files from:
CMyFont.hpp
CMyFont.cpp

@wearrrrr
Copy link
Contributor

wearrrrr commented Dec 2, 2024

Looks good to me :)

@KSSBrawl
Copy link
Contributor

KSSBrawl commented Dec 4, 2024

It might be prudent to replace WIDTH and HEIGHT with GAME_WINDOW_WIDTH and GAME_WINDOW_HEIGHT from GameWindow.hpp since in the original font.cpp those seem to be similar configurable values.

@Renzo904
Copy link
Member Author

Renzo904 commented Dec 5, 2024

It might be prudent to replace WIDTH and HEIGHT with GAME_WINDOW_WIDTH and GAME_WINDOW_HEIGHT from GameWindow.hpp since in the original font.cpp those seem to be similar configurable values.

To be honest, i totally forgot those existed😂

@roblabla roblabla merged commit 348cf93 into happyhavoc:master Dec 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roblabla roblabla roblabla left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Renzo904 @wearrrrr @KSSBrawl @roblabla