better naming and docs, remove unnecessary macro test, clippy fixes

omnipaxos/src/storage/internal_storage.rs

@@ -500,7 +500,7 @@ where
         } else if ss.is_none() && self.state_cache.stopsign.is_some() {
             self.state_cache.accepted_idx -= 1;
         }
-        self.state_cache.stopsign = ss.clone();
+        self.state_cache.stopsign.clone_from(&ss);
         self.storage.set_stopsign(ss)?;
         Ok(self.state_cache.accepted_idx)
     }

omnipaxos/src/storage/mod.rs

@@ -163,7 +163,7 @@ where
     /// If entries **do not exist for the complete interval**, an empty Vector should be returned.
     fn get_entries(&self, from: usize, to: usize) -> StorageResult<Vec<T>>;
 
-    /// Returns the current length of the log.
+    /// Returns the current length of the log (without the trimmed/snapshotted entries).
     fn get_log_len(&self) -> StorageResult<usize>;
 
     /// Returns the suffix of entries in the log from index `from` (inclusive).

omnipaxos/tests/snapshot_test.rs

@@ -126,7 +126,7 @@ fn double_snapshot_test() {
 }
 
 fn check_snapshot(
-    vec_proposals: &Vec<Value>,
+    vec_proposals: &[Value],
     snapshot_idx: usize,
     node: Arc<Component<OmniPaxosComponent>>,
 ) {

omnipaxos/tests/trim_test.rs

@@ -133,11 +133,7 @@ fn double_trim_test() {
     };
 }
 
-fn check_trim(
-    vec_proposals: &Vec<Value>,
-    trim_idx: usize,
-    node: Arc<Component<OmniPaxosComponent>>,
-) {
+fn check_trim(vec_proposals: &[Value], trim_idx: usize, node: Arc<Component<OmniPaxosComponent>>) {
     let num_proposals = vec_proposals.len();
     node.on_definition(|x| {
         let op = &x.paxos;

omnipaxos/tests/utils.rs

@@ -852,7 +852,7 @@ pub mod omnireplica {
         }
 
         pub fn is_connected_to(&self, pid: &NodeId) -> bool {
-            self.peer_disconnections.get(pid).is_none()
+            !self.peer_disconnections.contains(pid)
         }
 
         fn answer_election_future(&mut self, l: Ballot) {

omnipaxos_macros/tests/derive_test.rs

@@ -1,14 +1,3 @@
-#[test]
-fn derive_entry_test() {
-    use omnipaxos::macros::Entry;
-
-    #[derive(Clone, Debug, Entry)]
-    struct TestEntry {
-        pub _field1: u64,
-        pub _field2: String,
-    }
-}
-
 #[test]
 fn build_op_test() {
     use omnipaxos::{macros::Entry, ClusterConfig, OmniPaxos, OmniPaxosConfig, ServerConfig};

omnipaxos_storage/src/persistent_storage.rs

@@ -247,15 +247,15 @@ where
         Ok(())
     }
 
-    fn batch_set_stopsign(&mut self, s: Option<StopSign>) -> StorageResult<()> {
-        let stopsign = bincode::serialize(&s)?;
+    fn batch_set_stopsign(&mut self, ss: Option<StopSign>) -> StorageResult<()> {
+        let stopsign = bincode::serialize(&ss)?;
         self.write_batch.put(STOPSIGN, stopsign);
         Ok(())
     }
 
     fn batch_set_snapshot(&mut self, snapshot: Option<T::Snapshot>) -> StorageResult<()> {
-        let stopsign = bincode::serialize(&snapshot)?;
-        self.write_batch.put(SNAPSHOT, stopsign);
+        let s = bincode::serialize(&snapshot)?;
+        self.write_batch.put(SNAPSHOT, s);
         Ok(())
     }
 }
@@ -441,8 +441,8 @@ where
     }
 
     fn set_snapshot(&mut self, snapshot: Option<T::Snapshot>) -> StorageResult<()> {
-        let stopsign = bincode::serialize(&snapshot)?;
-        self.db.put(SNAPSHOT, stopsign)?;
+        let s = bincode::serialize(&snapshot)?;
+        self.db.put(SNAPSHOT, s)?;
         Ok(())
     }