Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version bump #20

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions Dockerfile
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
###### Build #####
FROM node:12-slim AS node
FROM node:16-slim AS node
LABEL author="Harry Ho"
WORKDIR /
COPY . .
Expand All @@ -15,8 +15,8 @@ COPY --from=node /dist /usr/share/nginx/html
COPY ./config/nginx.conf /etc/nginx/conf.d/default.conf


# ########################
# # docker build . -t vc-prd:2.0
# # docker run --publish 8080:80 --name vc2 vc-prd:2.0
########################
# docker build . -t vc-prd:2.0
# docker run --publish 8080:80 --name vc2 vc-prd:2.0


2 changes: 1 addition & 1 deletion README.md
Original file line number Diff line number Diff line change
Expand Up @@ -90,7 +90,7 @@ docker build . -t vc-prd:2.0
docker run --rm -d --publish 8080:80 --name vc2 vc-prd:2.0

# Check the log
docker logs vc2 -f
docker logs vc2 -f

```

Expand Down
Loading