Removed namespace from cluster role

[NahisWayard]

Changes proposed in this PR

• Remove namespace declaration from the ClusterRole in the helm chart

How I've tested this PR

• Locally using helm install

How I expect reviewers to test this PR

• Deploying consul the same as they used to and noticed no changes

Checklist

• Not needed - Tests added
• CHANGELOG entry added

[hashicorp-cla-app]

All committers have signed the CLA.

[hashicorp-cla-app]

Thank you for your submission! We require that all contributors sign our Contributor License Agreement ("CLA") before we can accept the contribution. Read and sign the agreement

Learn more about why HashiCorp requires a CLA and what the CLA includes

_{Have you signed the CLA already but the status is still pending? Recheck it.}

[blake]

Hi @NahisWayard, thanks for this PR.

I'm assuming you want to remove this because ClusterRole is not a namespaced resource. Would it be too much to ask for you to explain that in the PR description as well as the commit message so that it is easier for others to understand the reason behind this change?

Also, would you be opposed to expanding this PR to remove namespace from all ClusterRole resources in the Helm chart? I did a quick search and only found it present in the ClusterRole for Consul CNI, but it wouldn't hurt to verify that there aren't other ClusterRoles with this unnecessary field.

consul-k8s/charts/consul/templates/cni-clusterrole.yaml

Line 6 in 7e1efe4

namespace: {{ default .Release.Namespace .Values.connectInject.cni.namespace }}

Thanks again.

[blake]

Suggested change

	helm: Removed useless namespace specification on CLusterRole
	helm: Removed namespace specification on ClusterRole