Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove staff codeowners now that it requires mandatory review #22020

Merged
merged 1 commit into from
Dec 18, 2024
Merged

chore: remove staff codeowners now that it requires mandatory review #22020

merged 1 commit into from
Dec 18, 2024

Conversation

rboyer
Copy link
Member

@rboyer rboyer commented Dec 18, 2024

Description

The staff codeowners line items were added when the codeowners files were non-mandatory, to be used as a notification only. Now that the codeowners file requires mandatory review the spirit of the original change isn't correct anymore.

@rboyer rboyer added pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test backport/all Apply backports for all active releases per .release/versions.hcl labels Dec 18, 2024
@rboyer rboyer self-assigned this Dec 18, 2024
@rboyer rboyer requested a review from a team as a code owner December 18, 2024 22:19
@github-actions github-actions bot added the theme/contributing Additions and enhancements to community contributing materials label Dec 18, 2024
@rboyer rboyer merged commit 507b97d into main Dec 18, 2024
123 checks passed
@rboyer rboyer deleted the rboyer/remove-staff-codeowners branch December 18, 2024 22:36
@hc-github-team-consul-core hc-github-team-consul-core added backport/1.20 Changes are backported to 1.20 backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent labels Dec 18, 2024
@hc-github-team-consul-core hc-github-team-consul-core mentioned this pull request Dec 18, 2024
Merged
@hc-github-team-consul-core
Copy link
Collaborator

📣 Hi @rboyer! a backport is missing for this PR [22020] for versions [1.15,1.18,1.19,1.20] please perform the backport manually and add the following snippet to your backport PR description:

<details>
	<summary> Overview of commits </summary>
		- <<backport commit 1>>
		- <<backport commit 2>>
		...
</details>

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sarahalsmiller sarahalsmiller sarahalsmiller approved these changes

Assignees

@rboyer rboyer

Labels
backport/all Apply backports for all active releases per .release/versions.hcl backport/ent/1.15 Changes are backported to 1.15 ent backport/ent/1.18 Changes are backported to 1.18 ent backport/ent/1.19 Changes are backported to 1.19 ent backport/1.20 Changes are backported to 1.20 pr/no-changelog PR does not need a corresponding .changelog entry pr/no-metrics-test theme/contributing Additions and enhancements to community contributing materials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rboyer @hc-github-team-consul-core @sarahalsmiller