Replace bolt dependency with bbolt #22030
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are some dependencies that still depends on the unmaintained bolt after hashicorp#11720. Replace it so that we can have one less dependency, and build on newer architecture like RISC-V. Two lines of replace are required because Go refuses to replace github.com/boltdb/bolt with go.etcd.io/bbolt when the latter is also present in the dependency tree. Replace it again with github.com/etcd-io/bbolt solves the issue.
|
|
github-actions
bot
added
the
pr/dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
There are some dependencies that still depends on the unmaintained bolt after #11720. Replace it so that we can have one less dependency, and build on newer architecture like RISC-V.
Two lines of replace are required because Go refuses to replace github.com/boltdb/bolt with go.etcd.io/bbolt when the latter is also present in the dependency tree. Replace it again with github.com/etcd-io/bbolt solves the issue.
Testing & Reproduction steps
No bugs, just replacing one unmaintained dependency with the maintained fork.
Links
We built Consul successfully on Arch Linux RISC-V: https://github.com/felixonmars/archriscv-packages/blob/8c237b29417eb927f57c42f3b30d33eb855e6e53/consul/riscv64.patch
PR Checklist