All configuration related code has been moved to a separate package #271
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o that it can be imported into external projects
|
|
|
@hashicorp/api-tooling-core |
|
Hey @Eitol, sorry for the delay responding. Meant to review this today (I reserve Mondays to look at community messages) but didn't make it. I'll take a look tomorrow. |
eikenb
reviewed
Nov 17, 2021
| @@ -4,6 +4,7 @@ import ( | |||
| "bytes" | |||
| "encoding/json" | |||
| "fmt" | |||
| config2 "github.com/hashicorp/envconsul/config" | |||
There was a problem hiding this comment.
Would you please consider aligning the naming of the imports so the module has the same name everywhere. You used cfg above which is fine and wouldn't conflict with the consul-template/config package. Please don't use config2 (to close to existing config for my tastes).
eikenb
reviewed
Nov 17, 2021
| @@ -2,6 +2,7 @@ package main | |||
|
|
|||
| import ( | |||
| "fmt" | |||
| config2 "github.com/hashicorp/envconsul/config" | |||
There was a problem hiding this comment.
Same as above. Please use the same name everywhere.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #270