-
Notifications
You must be signed in to change notification settings - Fork 457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(lib): add resource move functionality #3152
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ansgarm
reviewed
Oct 2, 2023
ansgarm
reviewed
Oct 2, 2023
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: hashicorp-copywrite[bot] <110428419+hashicorp-copywrite[bot]@users.noreply.github.com>
…sourceId function
…cs, python move example
I'm going to lock this pull request because it has been closed for 30 days. This helps our maintainers find and focus on the active issues. If you've found a problem that seems related to this change, please open a new issue and complete the issue template so we can capture all the details necessary to investigate further. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes #1292
Fixes #219
Description
PR adds support for
moved
block functionality– though only in function not form.Instead of directly porting over the form of Terraform’s moved block into CDKTF, use case specific functions that leverage the functionality of the moved block have been created. Additionally, instead of using a direct reference, or directly specifying the resource Ids to move from/to, a resource targeting system is used to more simply mark and later identify the location of the move.
New Functions On TerraformResource
addMoveTarget(moveTarget: string)
:Adds a string moveTarget to the resource it is called upon.
This
moveTarget
can then be accessed in any place within the stack, including nested Constructs.moveTo(moveTarget: string, index?: string | number)
:Performs the move operation from the resource it is being called upon to the moveTarget specified
Example Output
In Typescript
In Python
Other Notes
I've forgone including integration tests as I believe unit testing should be sufficient (see additions to
resource.test.ts
). Seems to me that any issue not caught by them would be a problem on the side of Terraform.