Add cn_validations property to pki_secret_backend_role #1820
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bmhughes
force-pushed
the
add-pki-role-cn-validations
branch
from
0784323 to
0d4f2e2
Compare
bmhughes
force-pushed
the
add-pki-role-cn-validations
branch
from
0d4f2e2 to
87713da
Compare
bmhughes
force-pushed
the
add-pki-role-cn-validations
branch
2 times, most recently
from
8ed1156 to
36fae4c
Compare
|
closes #1883 |
bmhughes
force-pushed
the
add-pki-role-cn-validations
branch
from
36fae4c to
e60abfa
Compare
|
Rebased on current |
stevendpclark
requested changes
Nov 26, 2024
There was a problem hiding this comment.
Thanks @bmhughes for this contribution!
Would you mind updating the PR against main, addressing my small ask around augmenting the tests. Also we will need a changelog entry within CHANGELOG.md, something like this would do.
* Update `vault_pki_secret_backend_role` to support the `cn_validations` role field ([#1820](https://github.com/hashicorp/terraform-provider-vault/pull/1820)).
bmhughes
force-pushed
the
add-pki-role-cn-validations
branch
from
e60abfa to
c478ba4
Compare
|
Hi @stevendpclark, thanks for the feedback. I've implemented those changes, let me know if there's anything else! |
stevendpclark
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Community Note
Relates OR Closes #0000
Release note for CHANGELOG:
Output from acceptance testing: