Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use single runner label for custom-linux-large runner #2241

Merged
merged 1 commit into from
May 16, 2024

Conversation

dlaguerta
Copy link
Contributor

Description

👋 Greetings!

To align with Github’s removal of custom labels on larger runners, this PR is removing extra custom labels defined in your Github Actions. Moving forward, only one label (the github runner name) will be needed to ensure the appropriate larger runner is used for your GHA job.

Please review for accuracy and merge before May 27, 2024. Thank you!

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccXXX'

...

Community Note

  • Please vote on this pull request by adding a 👍 reaction to the original pull request comment to help the community and maintainers prioritize this request
  • Please do not leave "+1" comments, they generate extra noise for pull request followers and do not help prioritize the request

@fairclothjm fairclothjm marked this pull request as ready for review May 16, 2024 14:58
@fairclothjm fairclothjm merged commit faab4d8 into main May 16, 2024
14 of 15 checks passed
@fairclothjm fairclothjm deleted the PSS-139-single-runner-labels branch May 16, 2024 19:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants