Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add subscribe to list of allowed capabilities #2293

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

gg718
Copy link
Contributor

@gg718 gg718 commented Jul 11, 2024

For Vault Enterprise users, subscribe is a valid capability (ref) and should be included in the list of allowed capabilities.

Copy link

hashicorp-cla-app bot commented Jul 11, 2024

CLA assistant check
All committers have signed the CLA.

@gg718
Copy link
Contributor Author

gg718 commented Dec 12, 2024

What's the hold up in getting this merged?

This is a one-line change for an Enterprise-only feature (that HashiCorp customers pay a significant amount in subscription fees for) and it's been open for 5 months without as much as an acknowledgement...

fairclothjm
fairclothjm previously approved these changes Dec 12, 2024
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gg718 and I apologize for the delay!

@fairclothjm fairclothjm added this to the 4.6.0 milestone Dec 12, 2024
@fairclothjm fairclothjm force-pushed the capabilities-subscribe branch from cb0be60 to bb0ebf4 Compare December 12, 2024 16:45
@fairclothjm fairclothjm requested a review from a team as a code owner December 12, 2024 16:45
@fairclothjm fairclothjm requested review from yankun91 and a team December 12, 2024 16:45
@fairclothjm
Copy link
Contributor

Thanks @gg718 and @VioletHynes !

@fairclothjm fairclothjm merged commit 78f2eda into hashicorp:main Dec 12, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants