Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new fields to Postgres to enable Rootless Configuration for Static Roles #2341

Merged
merged 6 commits into from
Nov 11, 2024

Conversation

vinay-gopalan
Copy link
Contributor

Description

Adds support for the Vault 1.18+ Ent feature of Rootless Password Rotation and Configuration for Static Roles. Currently the feature is only enabled for the Postgres engine.

Checklist

  • Added CHANGELOG entry (only for user-facing changes)
  • Acceptance tests where run against all supported Vault Versions

Output from acceptance testing:

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendConnection_postgresql_rootlessConfig'
=== RUN   TestAccDatabaseSecretBackendConnection_postgresql_rootlessConfig
    resource_database_secret_backend_connection_test.go:876: Vault server version "1.18.0+ent"
--- PASS: TestAccDatabaseSecretBackendConnection_postgresql_rootlessConfig (0.77s)
PASS

$ make testacc TESTARGS='-run=TestAccDatabaseSecretBackendStaticRole_Rootless'
=== RUN   TestAccDatabaseSecretBackendStaticRole_Rootless
    resource_database_secret_backend_static_role_test.go:172: [TRACE] Creating test user
--- PASS: TestAccDatabaseSecretBackendStaticRole_Rootless (4.82s)
PASS

@vinay-gopalan vinay-gopalan requested a review from a team October 14, 2024 21:08
Copy link
Contributor

@fairclothjm fairclothjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@fairclothjm fairclothjm added this to the 4.5.0 milestone Oct 15, 2024
@vinay-gopalan vinay-gopalan merged commit e720115 into main Nov 11, 2024
11 checks passed
@vinay-gopalan vinay-gopalan deleted the VAULT-29855/rootless-static-roles-pgx branch November 11, 2024 18:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants