Add new resource vault_pki_secret_backend_acme_eab to manage ACME EAB tokens #2367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
victorr
previously approved these changes
Nov 29, 2024
| page_title: "Vault: vault_pki_secret_backend_acme_eab resource" | ||
| sidebar_current: "docs-vault-resource-pki-secret-backend-acme-eab" | ||
| description: |- | ||
| Sets the EST configuration on a PKI Secret Backend for Vault. |
There was a problem hiding this comment.
You may have overlooked updating this description.
|
|
||
| * `role` - (Optional) Create an EAB token that is specific to a role's ACME directory. | ||
|
|
||
| **NOTE**: EAB tokens are specific to an ACME directory. Within Vault ACME there are different |
There was a problem hiding this comment.
I am not very familiar with the ACME terminology, but maybe the sentence can be simplified to
Within Vault there are different ACME directories.
And maybe end the sentence with semicolons?
There was a problem hiding this comment.
Tweaked it a bit.
…2587-add-support-for-acme-eab-tokens
stevendpclark
deleted the
stevendpclark/vault-32587-add-support-for-acme-eab-tokens
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add a new resource called
vault_pki_secret_backend_acme_eabthat allows TFVP to create and delete EAB tokens (External Account Bindings). These tokens allow someone to restrict who can create a new ACME account within a particular ACME directory within Vault.Relates #1947
Checklist
Output from acceptance testing:
Community Note