Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Fallback parameters matching Vault PR #2375

Merged
merged 9 commits into from
Dec 11, 2024
Merged

Add Fallback parameters matching Vault PR #2375

merged 9 commits into from
Dec 11, 2024

Conversation

kpcraig
Copy link
Contributor

@kpcraig kpcraig commented Dec 2, 2024 •
edited
Loading

This is the TFVP parity PR for hashicorp/vault#29051

@kpcraig kpcraig requested a review from a team as a code owner December 2, 2024 17:24
@kpcraig kpcraig requested a review from anwittin December 2, 2024 17:24
Zlaticanin
Zlaticanin previously approved these changes Dec 10, 2024
View reviewed changes
Copy link
Contributor

@Zlaticanin Zlaticanin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

vinay-gopalan
vinay-gopalan reviewed Dec 11, 2024
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking great so far! Had a comment on adding a couple more test steps. Could we also update the docs and include the new fields? Thanks!

vault/resource_aws_secret_backend_test.go Show resolved Hide resolved
vault/resource_aws_secret_backend_test.go Show resolved Hide resolved
vinay-gopalan
vinay-gopalan previously approved these changes Dec 11, 2024
View reviewed changes
Copy link
Contributor

@vinay-gopalan vinay-gopalan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, had a non-blocking comment on adding version constraints to the docs

website/docs/r/aws_secret_backend.html.md Outdated Show resolved Hide resolved
@kpcraig kpcraig merged commit cac5adf into main Dec 11, 2024
1 check passed
@kpcraig kpcraig deleted the VAULT-32804/sts-fallback-endpoints branch December 11, 2024 21:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vinay-gopalan vinay-gopalan vinay-gopalan approved these changes

@Zlaticanin Zlaticanin Zlaticanin left review comments

@anwittin anwittin Awaiting requested review from anwittin anwittin is a code owner automatically assigned from hashicorp/vault

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kpcraig @Zlaticanin @vinay-gopalan