New Departure card for "next" HASL v4 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Clarify addition process
Update README.md
[hasl-sensor#12](hasl-sensor#12) Only show "Last updated" info if it was updated longer than x minutes ago
Reference captured `config` instead of reading from `this`
make compact true by default
Fixed bus name replacements
…-browsers Fix for old browsers without support for toLocaleString
Fixes hasl-sensor#30, Fixes hasl-sensor#23
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disclaimer: consider this a groundwork/refactoring PR, and not a finished feature
NOT COMPATIBLE with HASL3 prior to "4.0.0" (this commit)
Some functionality is dropped from the card (but should be very easy to get back before release).
The configuration is also cleaned up in favour of more descriptive names.
This PR contains:
devwithmasterThis should raise maintainability and decrease confusion for potential contributors
* Click action is the only thing that should be configured by hand
PS:
@DSorlov, we should probably align how we should move forward this "new api" effort.
Right now I have a feeling that my urge to make things "better" (and breaking existing stuff along the way ofc.) might not align with your long-term plans for HASL in general.