Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix missing scalar alias generation, add Accept header and improve response decoding #43

Merged
merged 3 commits into from
Dec 13, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Dec 12, 2024

  • Fix missing scalar type alias from primitive scalars.
  • Add the Accept request header with the value from the response content type.
  • Decode the response in JSON/XML format if the content type contains +json or +xml suffix.
  • Mask sensitive headers that are forwarded from the v3-engine

Copy link

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-http/connector 50%
github.com/hasura/ndc-http/connector/internal/argument 52%
github.com/hasura/ndc-http/connector/internal 55%
github.com/hasura/ndc-http/connector/internal/contenttype 57%
github.com/hasura/ndc-http/connector/internal/security 60%
github.com/hasura/ndc-http/ndc-http-schema/configuration 40%
github.com/hasura/ndc-http/ndc-http-schema/openapi/internal 50%
github.com/hasura/ndc-http/ndc-http-schema/openapi 40%
github.com/hasura/ndc-http/ndc-http-schema/schema 30%
github.com/hasura/ndc-http/ndc-http-schema/utils 43%
Summary 48% (4051 / 8423)

Minimum allowed line rate is 40%

@hgiasac hgiasac changed the title cli: fix missing scalar alias generation fix missing scalar alias generation, add Accept header and improve response decoding Dec 13, 2024
@hgiasac hgiasac merged commit 2ec5ce8 into main Dec 13, 2024
4 checks passed
@hgiasac hgiasac deleted the fix/scalar-generation branch December 13, 2024 05:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant