Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: incorrect urlencode encoding for JSON scalar, argument preset init #44

Merged
merged 6 commits into from
Dec 15, 2024

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Dec 13, 2024

  • Fix incorrectly encoding Arbitrary JSON scalar for application/x-www-form-urlencoded content type.
  • Fix argument preset initialization in server settings.
  • Disable HTML escape when encoding JSON.
  • Reroute HTTP 4xx response from the remote request to HTTP 422 so the detail can appear in the graphql error.
  • Use JSON for the result type if the response is unknown.

Copy link

github-actions bot commented Dec 13, 2024

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-http/connector 50%
github.com/hasura/ndc-http/connector/internal/argument 52%
github.com/hasura/ndc-http/connector/internal 56%
github.com/hasura/ndc-http/connector/internal/contenttype 58%
github.com/hasura/ndc-http/connector/internal/security 60%
github.com/hasura/ndc-http/ndc-http-schema/configuration 40%
github.com/hasura/ndc-http/ndc-http-schema/openapi/internal 49%
github.com/hasura/ndc-http/ndc-http-schema/openapi 40%
github.com/hasura/ndc-http/ndc-http-schema/schema 30%
github.com/hasura/ndc-http/ndc-http-schema/utils 43%
Summary 48% (4109 / 8513)

Minimum allowed line rate is 40%

@hgiasac hgiasac changed the title fix: incorrect urlencode encoding for JSON scalar fix: incorrect urlencode encoding for JSON scalar, argument preset init Dec 14, 2024
@hgiasac hgiasac merged commit 367d03a into main Dec 15, 2024
4 checks passed
@hgiasac hgiasac deleted the fix/urlencode-deepobject-scalar-json branch December 15, 2024 02:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant