Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cli: improve openapi union types conversion #46

Merged
merged 9 commits into from
Dec 21, 2024
Merged

Conversation

hgiasac
Copy link
Collaborator

@hgiasac hgiasac commented Dec 18, 2024

Improve OpenAPI union types conversion (oneOf, anyOf, allOf) with merging strategy:

  • allOf: all object fields are merged into a big object.
  • oneOf, anyOf: similar to allOf but all fields are optional except common fields.

Copy link

github-actions bot commented Dec 18, 2024

Code Coverage

Package Line Rate Health
github.com/hasura/ndc-http/connector 62%
github.com/hasura/ndc-http/connector/internal/argument 52%
github.com/hasura/ndc-http/connector/internal 55%
github.com/hasura/ndc-http/connector/internal/contenttype 56%
github.com/hasura/ndc-http/connector/internal/security 60%
github.com/hasura/ndc-http/ndc-http-schema/configuration 40%
github.com/hasura/ndc-http/ndc-http-schema/openapi/internal 45%
github.com/hasura/ndc-http/ndc-http-schema/openapi 40%
github.com/hasura/ndc-http/ndc-http-schema/schema 32%
github.com/hasura/ndc-http/ndc-http-schema/utils 44%
github.com/hasura/ndc-http/ndc-http-schema/version 26%
Summary 48% (4399 / 9253)

Minimum allowed line rate is 40%

@hgiasac hgiasac marked this pull request as ready for review December 21, 2024 00:29
@hgiasac hgiasac merged commit ddf3d32 into main Dec 21, 2024
4 checks passed
@hgiasac hgiasac deleted the improve-anyof-oneof branch December 21, 2024 00:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant