Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reformat EtherAddressValidator for EVMAddressValidator #1452

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

XMRZombie
Copy link
Contributor

This will avoid to create a new class everytime an EVM cryptocurrency is integrated

Using this address validation for all EVM addresses instead of only Ethereum
Using EVMAddressValidator instead of EtherAddressValidator
Using EVMAddressValidator instead of EtherAddressValidator
@XMRZombie XMRZombie requested a review from woodser as a code owner December 3, 2024 14:30
@woodser
Copy link
Contributor

woodser commented Dec 5, 2024

Isn't this really an ERC20 validator, in which case it makes sense to rename to Erc20Validator ?

@XMRZombie
Copy link
Contributor Author

I renamed EVMValidator because most of altcoins forked or inspired from Ethereum uses the same address formatting/validation.
ERC20 is for Ethereum only

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants