Remove price feed #1455
Draft
Remove price feed #1455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree that relying on centralized exchanges is dangerous. However, we would need to get the price from somewhere. So either one of the networks has to be big enough to be its own price oracle or we have to wait for something like serai. Without at least one of those things, people would just be pulling price from trading view or a centralized exchange manually in order to figure out where to set their prices. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It has been mentioned by a user that using price feeds from centralized exchanges is counterintuitive and potentially dangerous. This PR is a beginning step for removing the price feed. It currently does nothing but remove the price feed UI element (which also means that wallet balances are not shown). This is not currently ready for integration, and I will not do any more work on this unless further interest in the removal of the price feeds is shown.