Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build improvements #3155

Draft
wants to merge 40 commits into
base: main
Choose a base branch
from
Draft

Conversation

Vanmodeus
Copy link
Collaborator

As described in #3152 the build process depends on a local git installation. Furthermore, the build process checks the current OS to execute specific Pre/PostBuildEvents and scripts (PreBuildEvent.cmd/.sh | MergeConfigs.cmd/.sh | ConfigMerger.exe) which leads to additional maintenance effort. To reduce these OS/machine specific dependencies, I've created a new .net standard 2.0 solution called HeuristicLab.Build, which includes the existing Pre/PostBuildEvents as MSBuild-Tasks and changed the existing .csproj files to utilize these new build tasks. The Version (revision to be more precise) uses minutes since midnight as a fallback if something goes wrong with git.

Please let me know what you think about this solution and if it also works on your machine.

@Vanmodeus Vanmodeus requested a review from mkommend April 11, 2022 14:30
@Vanmodeus Vanmodeus self-assigned this Apr 11, 2022
@mkommend mkommend removed their request for review April 27, 2022 11:40
@gkronber
Copy link
Member

When a Plugin.cs.frame file contains an empty line the PreBuildEvent inserts the output "ECHO ON" into the generated Plugin.cs file.
I suspect the problem is in PreBuildEvent.cmd line 26 when "!modified!" is empty.
Proposed fix: if a line is empty then just output an empty line (without any replacements).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants