WIP: Wait for workers before starting master #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...before starting master process Part of the fix for hellofresh/kangal#332
thiagoarrais
force-pushed
the
wait-for-workers
branch
from
e31bc8b to
2c2413a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR modifies the launcher script to wait for the workers to become online before starting the JMeter master. It depends on hellofresh/kangal#368 that introduces a
WORKER_TOTALenvironment variable specifying the number of expected workers.This should fix hellofresh/kangal#332. It should also fix the related problem of repeated master output on the pod logs caused by
cating the output inside the wait loop. When there wasn't any worker, JMeter wouldn't finish and every check for completion would spit the same output over and over again.Marked as WIP for depending on a not yet merged PR