Add support for PAN hotfix releases. #281
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hellt
reviewed
Nov 19, 2024
| @@ -6,7 +6,7 @@ IMAGE_GLOB=*.qcow2 | |||
| # match versions like: | |||
| # PA-VNM-KVM-7.0.1.qcow2 | |||
| # PA-VM-KVM-10.0.6.qcow2 | |||
| VERSION=$(shell echo $(IMAGE) | sed -e 's/.*-\([0-9]\{1,2\}\.[0-9]\{1,2\}.[0-9]\{1,2\}\)\.qcow2$$/\1/') | |||
| VERSION=$(shell echo $(IMAGE) | sed -e 's/.*-\([0-9]\{1,2\}\.[0-9]\{1,2\}.[0-9]\{1,2\}\(\|-h[0-9]\{1,2\}\)\)\.qcow2$$/\1/') | |||
There was a problem hiding this comment.
for some platforms we started to move away from the arcane sed/grep expressions in favor of a more simple one where a user renames the image to have a simple versioning scheme. Like this:
https://github.com/hellt/vrnetlab/blob/master/huawei_vrp/Makefile#L9
it makes it easier for us (and users) to just rename the qcow to have a predefined prefix, and then format the version the way that want it to be
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor regular expression update to support hotfix releases.
An example of this is PA-VM-KVM-11.1.2-h3.qcow2.