Skip to content

Commit

Permalink
f2fs: fix to overcome inline_data floods
Browse files Browse the repository at this point in the history
The scenario is:
1. create lots of node blocks
2. sync
3. write lots of inline_data
-> got panic due to no free space

In that case, we should flush node blocks when writing inline_data in armani-dev#3,
and trigger gc as well.

Signed-off-by: Jaegeuk Kim <[email protected]>
  • Loading branch information
Jaegeuk Kim authored and hemantbeast committed May 6, 2018
1 parent ace9a20 commit 66061f5
Showing 1 changed file with 7 additions and 0 deletions.
7 changes: 7 additions & 0 deletions fs/f2fs/gc.c
Original file line number Diff line number Diff line change
Expand Up @@ -835,8 +835,15 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync)

if (gc_type == BG_GC && has_not_enough_free_secs(sbi, sec_freed)) {
gc_type = FG_GC;
/*
* If there is no victim and no prefree segment but still not
* enough free sections, we should flush dent/node blocks and do
* garbage collections.
*/
if (__get_victim(sbi, &segno, gc_type) || prefree_segments(sbi))
write_checkpoint(sbi, &cpc);
else if (has_not_enough_free_secs(sbi, 0))
write_checkpoint(sbi, &cpc);
}

if (segno == NULL_SEGNO && !__get_victim(sbi, &segno, gc_type))
Expand Down

0 comments on commit 66061f5

Please sign in to comment.