Print more apps info #211

mmowris · 2017-12-05T23:18:55Z

Begun adding more info from --json to apps:info. Only begun by adding buildpacks and dyno size. Happy to take thoughts

// new
Dynos:      email-wrkr: 1 Standard-1X Dyno
            web: 2 Standard-1X Dynos 
// current
Dynos:          email-wrkr: 1, web: 2

// net new
// can add logic for custom buildpacks w/o name, ex: elixir, to create name from url
Buildpacks:     https://github.com/HashNuke/heroku-buildpack-elixir.git
                nodejs
                python

cc: @RasPhilCo @jdxcode

jdx · 2017-12-06T19:09:30Z

src/commands/apps/info.js

@@ -8,6 +8,8 @@ function * run (context, heroku) {
  const util = require('util')
  const S = require('string')
  const countBy = require('lodash.countby')
+  //const filter = require('lodash.filter')
+  const _ = require('lodash');


this causes a big performance hit in the CLI if you require at the top of the file like this. I would rewrite it so you can use lodash functions by themselves rather than requiring everything. Unfortunately this means you won't be able to use chain though. I can give you a hand optimizing it if you like.

jdx · 2017-12-06T19:10:10Z

-H

@@ -0,0 +1 @@
+{"id":"missing_version","error":"Please specify a version along with Heroku's API MIME type. For example, `Accept: application/vnd.heroku+json; version=3`.\n"}


this file shouldn't be included

jdx · 2017-12-06T19:10:36Z

love the new output @mmowris, let's work a bit to improve the performance of it though

Matthew Mowris added 3 commits December 5, 2017 14:54

update Dynos to show dyno size

bc3ebcd

add buildpacks to apps:info

f4f9945

remove console.log(buildpacks)

bb79c13

jdx reviewed Dec 6, 2017

View reviewed changes

add owner team, last release date

882d454

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Print more apps info #211

Print more apps info #211

mmowris commented Dec 5, 2017 •

edited

Loading

jdx Dec 6, 2017

jdx Dec 6, 2017

jdx commented Dec 6, 2017

		@@ -0,0 +1 @@
		{"id":"missing_version","error":"Please specify a version along with Heroku's API MIME type. For example, `Accept: application/vnd.heroku+json; version=3`.\n"}

Print more apps info #211

Are you sure you want to change the base?

Print more apps info #211

Conversation

mmowris commented Dec 5, 2017 • edited Loading

jdx Dec 6, 2017

Choose a reason for hiding this comment

jdx Dec 6, 2017

Choose a reason for hiding this comment

jdx commented Dec 6, 2017

mmowris commented Dec 5, 2017 •

edited

Loading