Updates default host to api.data.heroku.com #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zwhitfield3
force-pushed
the
update-to-data-api
branch
from
bb6044a to
b10189a
Compare
sbosio
approved these changes
Feb 8, 2024
There was a problem hiding this comment.
Looks good to me. Maybe it will be a good idea at some point to define the default host for tests in a single constant instead of hardcoding it in each nock call so the next time we will only change a single place.
I left a comment on the Node version used for testing, but it's not a blocker, feel free to disregard it.
jdowning
reviewed
Feb 8, 2024
jdowning
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gus: https://gus.lightning.force.com/lightning/r/ADM_Work__c/a07EE00001eh1AJYAY/view