Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: drop support for python 3.8 #458

Merged
merged 2 commits into from
Nov 5, 2024
Merged

feat: drop support for python 3.8 #458

merged 2 commits into from
Nov 5, 2024

Conversation

jooola
Copy link
Member

@jooola jooola commented Oct 22, 2024

Python 3.8 is EOL since 07 Oct 2024.

https://devguide.python.org/versions/

Copy link

codecov bot commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.85%. Comparing base (a37aff4) to head (ebcdeac).
Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #458   +/-   ##
=======================================
  Coverage   92.85%   92.85%           
=======================================
  Files          64       64           
  Lines        2981     2981           
=======================================
  Hits         2768     2768           
  Misses        213      213           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jooola jooola requested a review from apricote October 22, 2024 13:50
@jooola
Copy link
Member Author

jooola commented Oct 31, 2024

Once we merge this, we might need to release a major version of the Ansible collection. I still need to check if this is a good timing.

@jooola jooola merged commit e74e319 into main Nov 5, 2024
10 checks passed
@jooola jooola deleted the drop-python-3.8 branch November 5, 2024 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants