Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: necessary features for hcloud-cloud-controller-manager #14

Merged
merged 1 commit into from
Jul 4, 2024
Merged

Conversation

apricote
Copy link
Member

@apricote apricote commented Jun 28, 2024

  • Variable to disable HCCM: We want to deploy this from the local sources
  • Variable to disable cloud routes: Does not work with Robot servers,
    which we use in one test suite
  • Output for the control-plane server: Used to join the Robot server
  • ENV_NAME in env.sh: Used in HCCM tests to find resources in the
    Cloud API

HCCM also requires the following other PRs to be merged. These are all stacked onto eachother:

@apricote apricote added the enhancement New feature or request label Jun 28, 2024
@apricote apricote changed the base branch from main to ssh-key-outputs July 3, 2024 08:37
@apricote apricote changed the title feat: make work in hcloud-cloud-controller-manager feat: necessary features for hcloud-cloud-controller-manager Jul 3, 2024
Base automatically changed from ssh-key-outputs to main July 3, 2024 08:46
variables.tf Show resolved Hide resolved
Copy link
Member

@jooola jooola left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really appreciate that you broke down the changes in easy to review PRs :)

- Variable to disable HCCM: We want to deploy this from the local sources
- Variable to disable cloud routes: Does not work with Robot servers,
  which we use in one test suite
- Output for the control-plane server: Used to join the Robot server
- `ENV_NAME` in `env.sh`: Used in HCCM tests to find resources in the
  Cloud API
@apricote apricote marked this pull request as ready for review July 4, 2024 12:39
@apricote apricote requested a review from a team as a code owner July 4, 2024 12:39
@apricote apricote merged commit d51ba12 into main Jul 4, 2024
2 checks passed
@apricote apricote deleted the hccm branch July 4, 2024 12:39
apricote pushed a commit that referenced this pull request Jul 4, 2024
🤖 I have created a release *beep* *boop*
---


##
[0.3.0](v0.2.0...v0.3.0)
(2024-07-04)


### Features

* change workers_count default to 1
([#16](#16))
([df359ff](df359ff))
* necessary features for hcloud-cloud-controller-manager
([#14](#14))
([d51ba12](d51ba12))
* write public key to local file
([#17](#17))
([88395fd](88395fd))

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants