Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Iris to version 12 #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

kataras
Copy link

@kataras kataras commented Oct 29, 2019

This commit contains all the necessary code and minor improvements to work with the latest Iris (v12.0.1) and Go 1.13. @john-deng ^

@john-deng
Copy link
Member

@kataras Thanks for your PR, iris makes the coding of hiboot much easier, however, we used previous on production, some of the iris features such as websocket are not compatible with the new version, it may take some time to fix this kind of issues. Also Travis CI build failed, please help to fix it as well.

@kataras
Copy link
Author

kataras commented Oct 31, 2019

Hello @john-deng, the websocket changed but as I've seen you copy-pasted the previous Iris websocket code right in this project at /pkg/starter/websocket folder so I assume you don't have to upgrade them if you don't want to. Some of the tests are failing but this is not because of the update, this will happen if you clone the project to a new machine and try to go test -v ./... as well (some of your deps are not compatible anymore with your app), I've fixed some of them with go modules but you can investigate more and do the rest as well.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants