enforce vector size for *combineAll laws as a workarround #321
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caenrique
changed the title
fedefernandez
approved these changes
Oct 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a workaround to #314 by overriding the Properties when including them in
StreamTestsand that way, being able to provide an instance ofArbitrary[Vector[Stream[Int]]]with a size limit of 10.Context
I wasn't able to reproduce this failing test locally at first, even when using the same seed.
that led me to believe that this was related to resources of the underlying runner (container/pod/jvm)
combineAll.This makes me think that there is a fundamental issue with the implementation of
Nuthat is making it not stack safe, but I couldn't find it.We'll need to dig deeper into this one at some point