Remove scalapb #64
Closed
Remove scalapb #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/test/scala/higherkindness/skeuomorph/protobuf/ProtobufSpec.scala
Outdated
Show resolved
Hide resolved
pepegar
reviewed
Feb 12, 2019
|
|
||
| final case class NativeOneOfField(name: String, tpe: NativeOneOf) extends NativeFieldF | ||
|
|
||
| sealed trait NativeDescriptor |
There was a problem hiding this comment.
What is the reason of using this ADT? why don't we use the ProtobufF directly? It looks like we have a 1 to 1 mapping in here.
There was a problem hiding this comment.
That was my first approach actually, but when I tried to express the conversion Coalgebra[ProtobufF, FileDescriptorProto] I realized that FileDescriptorProto is not algebraic enough. I can try again.
|
Closed in favor of #66 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes scalapb. I need to organize all the PRs related to protobuf.