Add record and var keywords to Groovy syntax #3872
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +10 B View Changes
|
|
Looks good, but please update CHANGES.md as well. |
Build Size ReportChanges to minified artifacts in 2 files changedTotal change +13 B View Changes
|
|
Sorry joshgoebel for missing the |
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +16 B View Changes
|
joshgoebel
reviewed
Oct 8, 2023
CHANGES.md
Outdated
| @@ -97,6 +97,7 @@ Core Grammars: | |||
| - enh(php) detect newer more flexible NOWdoc syntax (#3679) [Timur Kamaev][] | |||
| - enh(python) improve autodetection of code with type hinting any function's return type (making the `->` operator legal) [Keyacom][] | |||
| - enh(bash) add `select` and `until` as keywords | |||
| - enh(groovy) add `record` and `var` as keywords [Guillaume Laforge][] | |||
There was a problem hiding this comment.
You need to also add a subscript link on lines ~ 102-120.
|
I moved in the unreleased version as well, I realised I put it in the already released version |
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +10 B View Changes
|
joshgoebel
approved these changes
Oct 8, 2023
Build Size ReportChanges to minified artifacts in 5 files changedTotal change +7 B View Changes
|
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Groovy added support for
records like Java, and also allows the use ofvar(in addition todef) to define variables or specified non-typed arguments.