Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update: unix-kill resolve on exit. add error listener #103

Draft
wants to merge 20 commits into
base: main
Choose a base branch
from
Draft

update: unix-kill resolve on exit. add error listener #103

wants to merge 20 commits into from

Conversation

hilleer
Copy link
Owner

@hilleer hilleer commented Dec 21, 2023 •
edited
Loading

Fix #20

@hilleer hilleer marked this pull request as draft December 21, 2023 21:00
@socket-security Socket Security
Copy link

socket-security bot commented Dec 22, 2023 •
edited
Loading

New and removed dependencies detected. Learn more about Socket for GitHub ↗︎

Package New capabilities Transitives Size Publisher

View full report↗︎

hilleer
hilleer commented Dec 28, 2023
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
hilleer
hilleer commented May 14, 2024
View reviewed changes
src/lib/killer.ts
xargs.on('exit', (code) => {
const error = handleErrorCode(code);
if (error) {
reject(error);
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
reject(error);
return reject(error);

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dest.end is not a function
1 participant
@hilleer