feat: detect and fetch missing pox cycle signer sets #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://signer-metrics-b83xj354z-hirosystems.vercel.app 🚀 |
rafaelcr
reviewed
Oct 28, 2024
| } | ||
|
|
||
| private async fetchStackerSet(cycleNumber: number) { | ||
| while (!this.abortController.signal.aborted) { |
There was a problem hiding this comment.
Instead of an infinite loop that would keep a job alive indefinitely, could we use logic to re-add this cycle fetch to the back of the queue if it fails and let the PQueue handle the retry? With this infinite loop, if you have a cycle that gets stuck and you add more cycles to the queue there could be a situation where you stop processing new cycles altogether if you hit your CONCURRENCY_LIMIT
Perhaps not super urgent for now, though, could be done in another PR but I think it's something we should keep in mind
rafaelcr
approved these changes
Oct 28, 2024
blockstack-devops
pushed a commit
that referenced
this pull request
Oct 28, 2024
## [0.3.0](v0.2.2...v0.3.0) (2024-10-28) ### Features * detect and fetch missing pox cycle signer sets ([#16](#16)) ([501cfaa](501cfaa))
|
🎉 This PR is included in version 0.3.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #10