fix: rename url prefix from signer-monitor to signer-metrics #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://signer-metrics-8rljfn36q-hirosystems.vercel.app 🚀 |
rafaelcr
reviewed
Oct 28, 2024
| @@ -30,7 +30,7 @@ export async function buildApiServer(args: { db: PgStore }) { | |||
| await fastify.register(FastifyMetrics, { endpoint: null }); | |||
| } | |||
| await fastify.register(FastifyCors); | |||
| await fastify.register(Api, { prefix: '/signer-monitor' }); | |||
| await fastify.register(Api, { prefix: '/signer-metrics' }); | |||
There was a problem hiding this comment.
Kind of a nit but can you take this opportunity to also rename paths to plural so they're more REST-like? e.g.
https://api.hiro.so/signer-monitor/v1/cycle/{cycle_number}/signer/{signer_id}
becomes
https://api.hiro.so/signer-metrics/v1/cycles/{cycle_number}/signers/{signer_id}
blockstack-devops
pushed a commit
that referenced
this pull request
Oct 28, 2024
## [0.2.2](v0.2.1...v0.2.2) (2024-10-28) ### Bug Fixes * rename url prefix from signer-monitor to signer-metrics ([#17](#17)) ([529e1c6](529e1c6))
|
🎉 This PR is included in version 0.2.2 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.