Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support from/to time range query in cycle signers endpoint #37

Merged
merged 2 commits into from
Nov 5, 2024

Conversation

zone117x
Copy link
Member

@zone117x zone117x commented Nov 5, 2024

Closes #32

Add support for specifying a time range for the /v1/cycles/{n}/signers endpoint via query parameters.

Usage: ?from={timestamp}&to=${timestamp}

Where timestamp can be specified using relative time ranges and/or ISO timestamps, e.g.

  • ?from=now-2h&to=now (relative time ranges)
  • ?from=2024-11-01T15:16:53.891Z&to=2024-11-02T15:16:53.891Z (human readable ISO timestamp)

Copy link

github-actions bot commented Nov 5, 2024

Vercel deployment URL: https://signer-metrics-rmepsdh87-hirosystems.vercel.app 🚀

Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 86.00000% with 14 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
src/api/routes/cycle.ts 80.00% 6 Missing ⚠️
src/api/errors.ts 50.00% 4 Missing ⚠️
src/helpers.ts 89.74% 4 Missing ⚠️

📢 Thoughts on this report? Let us know!

@zone117x zone117x assigned janniks and unassigned janniks Nov 5, 2024
@zone117x zone117x requested a review from janniks November 5, 2024 12:41
Copy link
Contributor

@janniks janniks left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor find, otherwise looking crisp!

src/helpers.ts Outdated Show resolved Hide resolved
@zone117x zone117x merged commit a96736b into main Nov 5, 2024
5 checks passed
@zone117x zone117x deleted the feat/signers-time-range-query branch November 5, 2024 13:20
blockstack-devops pushed a commit that referenced this pull request Nov 5, 2024
## [0.5.0](v0.4.6...v0.5.0) (2024-11-05)

### Features

* support from/to time range query in cycle signers endpoint ([#37](#37)) ([a96736b](a96736b))
@blockstack-devops
Copy link

🎉 This PR is included in version 0.5.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Implement range support for /v1/cycles/{n}/signers endpoint
3 participants