Feat/signer last seen #38
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://signer-metrics-hcxx0jva3-hirosystems.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
janniks
approved these changes
Nov 5, 2024
| fastify.addHook('onSend', async (_req, reply, payload) => { | ||
| if ((reply.getHeader('Content-Type') as string).startsWith('application/json')) { | ||
| // Pretty-print with indentation | ||
| return JSON.stringify(JSON.parse(payload as string), null, 2); |
There was a problem hiding this comment.
I was trying to figure out how to optimize this using fast-json-stringify from fastify, but it doesn't look like it's built-in and would be a bit more complicated to maintain, to avoid the second stringify, as well as the parse.
There was a problem hiding this comment.
Same. I'm just leaving it here for now until we have a better view than the raw json in a web browser :D
|
🎉 This PR is included in version 0.6.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
Closes #23