feat: implement /v1/blocks/{hash_or_height} endpoint
#42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://signer-metrics-k6smqst84-hirosystems.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is
📢 Thoughts on this report? Let us know! |
zone117x
commented
Nov 8, 2024
Comment on lines
+174
to
+189
| test('get block by latest', async () => { | ||
| // Note: the current block payload test data does not have signer data for the latest block | ||
| const expectedBlockData: BlocksEntry = { | ||
| block_height: 112291, | ||
| block_hash: '0x82ac0b52a4dde86ac05d04f59d81081d047125d0c7eaf424683191fc3fd839f2', | ||
| block_time: 1730554958, | ||
| index_block_hash: '0x7183de5c4ae700248283fede9264d31a37ab3ca1b54b4fd24adc449fbbd4c2b7', | ||
| burn_block_height: 65206, | ||
| tenure_height: 53408, | ||
| }; | ||
|
|
||
| const { body: testBlockLatest } = (await supertest(apiServer.server) | ||
| .get(`/signer-metrics/v1/blocks/latest`) | ||
| .expect(200)) as { body: BlocksEntry }; | ||
| expect(testBlockLatest).toEqual(expectedBlockData); | ||
| }); |
There was a problem hiding this comment.
If a given block doesn't have signer metric data then no signer related information is returned. It should be possible to at least return the expected number of signers (from the cycle reward set), and number of accepted signers (number of signatures in the block).
blockstack-devops
pushed a commit
that referenced
this pull request
Nov 8, 2024
## [0.7.0](v0.6.0...v0.7.0) (2024-11-08) ### Features * implement `/v1/blocks/{hash_or_height}` endpoint ([#42](#42)) ([3ec299e](3ec299e))
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #25
Implement
/v1/blocks/{hash_or_height}endpoint.Can also take a
latestargGET /v1/blocks/latest