Merge pull request #265 from hirosystems/develop

release to master
hirosystems · Sep 23, 2024 · 9f03edd · 9f03edd
2 parents 0a04aab + 84252a7
commit 9f03edd
Show file tree

Hide file tree

Showing 3 changed files with 20 additions and 2 deletions.
diff --git a/src/pg/chainhook/block-cache.ts b/src/pg/chainhook/block-cache.ts
@@ -47,6 +47,7 @@ export class BlockCache {
   }
 
   transaction(tx: StacksTransaction) {
+    if (!tx.metadata.success) return;
     if (tx.metadata.kind.type === 'ContractDeployment' && tx.metadata.contract_abi) {
       const abi = tx.metadata.contract_abi as ClarityAbi;
       const sip = getSmartContractSip(abi);

diff --git a/tests/chainhook/smart-contracts.test.ts b/tests/chainhook/smart-contracts.test.ts
@@ -43,6 +43,23 @@ describe('contract deployments', () => {
     await expect(db.getPendingJobBatch({ limit: 1 })).resolves.toHaveLength(1);
   });
 
+  test('ignores token contract from a failed transaction', async () => {
+    await db.chainhook.processPayload(
+      new TestChainhookPayloadBuilder()
+        .apply()
+        .block({ height: 100 })
+        .transaction({
+          hash: '0x01',
+          sender: 'SP1K1A1PMGW2ZJCNF46NWZWHG8TS1D23EGH1KNK60',
+          success: false, // Failed
+        })
+        .contractDeploy('SP1K1A1PMGW2ZJCNF46NWZWHG8TS1D23EGH1KNK60.friedger-pool-nft', SIP_009_ABI)
+        .build()
+    );
+    await expect(db.getSmartContract({ id: 1 })).resolves.toBeUndefined();
+    await expect(db.getPendingJobBatch({ limit: 1 })).resolves.toHaveLength(0);
+  });
+
   test('ignores non-token contract', async () => {
     await db.chainhook.processPayload(
       new TestChainhookPayloadBuilder()

diff --git a/tests/helpers.ts b/tests/helpers.ts
@@ -1341,7 +1341,7 @@ export class TestChainhookPayloadBuilder {
     return this;
   }
 
-  transaction(args: { hash: string; sender?: string }): this {
+  transaction(args: { hash: string; sender?: string; success?: boolean }): this {
     this.lastBlock.transactions.push({
       metadata: {
         contract_abi: null,
@@ -1367,7 +1367,7 @@ export class TestChainhookPayloadBuilder {
         },
         result: '(ok true)',
         sender: args.sender ?? 'SP3HXJJMJQ06GNAZ8XWDN1QM48JEDC6PP6W3YZPZJ',
-        success: true,
+        success: args.success ?? true,
       },
       operations: [],
       transaction_identifier: {