fix: improve image cache error handling #214
Conversation
|
Vercel deployment URL: https://token-metadata-rfnpjwjsn-blockstack.vercel.app 🚀 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## beta #214 +/- ##
=======================================
Coverage ? 86.29%
=======================================
Files ? 44
Lines ? 5179
Branches ? 509
=======================================
Hits ? 4469
Misses ? 699
Partials ? 11 ☔ View full report in Codecov by Sentry. |
rafaelcr
changed the title
| // Cache the token so we can reuse it for other images. | ||
| process.env['IMAGE_CACHE_GCS_AUTH_TOKEN'] = json.access_token; | ||
| return json.access_token; | ||
| } catch (error) { | ||
| throw new Error(`Error fetching GCS access token: ${error.message}`); | ||
| throw new Error(`GCS access token error: ${error}`); |
There was a problem hiding this comment.
The @google-cloud/storage library can be used to handle the auth and upload a lot easier, it would be like 3-4 lines, I'm using it over here https://github.com/hirosystems/stacks-node-crawler/blob/720d4f9f79155a84a19c3d1028f0df1a54b3fbfb/src/index.ts#L5
E.g.
import { Storage } from '@google-cloud/storage';
const bucket = new Storage().bucket(myBucket); // auth handled automatically
const uploadStream = bucket.file(myfile).createWriteStream({ contentType: 'image/png' });
stream.pipe(uploadStream);
## [0.7.0-beta.5](v0.7.0-beta.4...v0.7.0-beta.5) (2024-05-13) ### Bug Fixes * improve image cache error handling ([#214](#214)) ([115a745](115a745))
|
🎉 This PR is included in version 0.7.0-beta.5 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
## [0.7.0](v0.6.3...v0.7.0) (2024-05-13) ### Features * add admin rpc to reprocess token image cache ([#205](#205)) ([2fdcb33](2fdcb33)) * update ts client with image thumbnails ([#206](#206)) ([c24cb56](c24cb56)) * upload token images to gcs ([#204](#204)) ([1cec219](1cec219)) ### Bug Fixes * get access token properly ([a6b98c5](a6b98c5)) * get gcs auth token dynamically for image cache ([#210](#210)) ([8434b22](8434b22)) * image cache agent arg types ([5826628](5826628)) * improve image cache error handling ([#214](#214)) ([115a745](115a745)) * reuse gcs token and validate image cache script errors ([#213](#213)) ([5e1af5c](5e1af5c))
|
🎉 This PR is included in version 0.7.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Add the option to handle different exit codes from the image cache script depending on error circumstances, to determine if the API should retry the cache later or not.