fix: treat non-compliant SIP-016 metadata as invalid #266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Vercel deployment URL: https://token-metadata-6qfjww3ic-hirosystems.vercel.app 🚀 |
Codecov ReportAll modified and coverable lines are covered by tests ✅ 📢 Thoughts on this report? Let us know! |
tippenein
approved these changes
Sep 23, 2024
blockstack-devops
pushed a commit
that referenced
this pull request
Sep 23, 2024
## [1.1.4](v1.1.3...v1.1.4) (2024-09-23) ### Bug Fixes * treat non-compliant SIP-016 metadata as invalid ([#266](#266)) ([288723d](288723d))
|
🎉 This PR is included in version 1.1.4 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We previously ignored JSON metadata that was not SIP-016 compliant (without a
namevalue at least) and processed the token silently, but this is an incorrect approach. This PR changes that so it fails and marks the token asinvalid.