Skip to content

Commit

Permalink
Merge pull request #197 from Enforcer/feedback-chapter_08_prettificat…
Browse files Browse the repository at this point in the history
…ion.asciidoc

Comments to chapter 8
  • Loading branch information
hjwp authored Oct 25, 2023
2 parents 7cf4875 + f333222 commit d52db44
Showing 1 changed file with 21 additions and 0 deletions.
21 changes: 21 additions & 0 deletions chapter_08_prettification.asciidoc
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,12 @@ http://grokcode.com/746/dear-python-why-are-you-so-ugly/[ugly],
so let's do a tiny bit of polishing.
Here's a few things we might want:

// SEBASTIAN: Is this remark about Python being ugly still relevant?
// Linked article is from 2012, that's like 11 years from now.
// Also, the article shows screenshots from multiple pages,
// including Django documentation or learnpython.org
// Both look completely different today - not so ugly anymore

* A nice large input field for adding new and existing lists
* A large, attention-grabbing, centered box to put it in

Expand Down Expand Up @@ -444,6 +450,11 @@ AssertionError: 103.333... != 512 within 10 delta (408.666...
----

Sure enough, they're still getting to exactly where they were before.

// SEBASTIAN: huh, is this consistent with TDD cycle you are teaching in previous
// chapters? I'd assume refactoring is made AFTER we get to green test 🤔
// Perhaps one could move the refactoring to happen BEFORE quick'n'dirty hack with text-align: center was reversed?

That's worthy of a commit:
((("Git", "diff -w")))

Expand Down Expand Up @@ -537,6 +548,9 @@ TIP: Take the time to browse through the
It's a shopping trolley brimming full of useful tools
to use in your site.

// SEBASTIAN: WDYT about linking directly do Docs page instead to index page of Bootstrap?
// I expected to see them instead of the same welcome page 😅

Does that work?

----
Expand All @@ -545,6 +559,11 @@ AssertionError: 103.333... != 512 within 10 delta (408.666...

Hmm. No. Why isn't our CSS loading?

// SEBASTIAN: I am not sure if this is in scope, but perhaps opening a browser,
// navigating to the application and showing in the console that loading
// of CSS failed (so the reader knows how to tackle such issues on their own)
// would be less of a magic? I imagine a newbie might be confused how the heck
// they were meant to guess it is CSS loading problem?


=== Static Files in Django
Expand Down Expand Up @@ -791,6 +810,8 @@ Adding the Bootstrap `table` class improves things, over in _list.html_:
In contrast to my greybeard nostalgia for the Jumbotron,
here's something relatively new to Bootstrap, Dark Mode!

// SEBASTIAN: Awesome! Dark mode is something many people want :D

[role="sourcecode"]
.lists/templates/base.html (ch08l017)
====
Expand Down

0 comments on commit d52db44

Please sign in to comment.